-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summer 2021 NEWS update #1303
Summer 2021 NEWS update #1303
Conversation
ca2d348
to
381908e
Compare
Co-authored-by: John Marshall <jmarshall@hey.com>
NEWS
Outdated
* Prevent assert in bcf_sr_set_regions. Thanks to Dr K D Murray. | ||
(#1270) | ||
|
||
* Fixed the update of the minimum offset when unmapped reads are present. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a serious bug that should be more clearly described, placed at the top of the list, and probably noted in samtools's NEWS as well. Perhaps something like
Fixed
hts_itr_query()
et al region queries: fixed bug introduced in HTSlib 1.12, which lead to iterators producing very few reads for some queries (especially for larger target regions) when unmapped reads were present. (HTSlib 1.11 had a related problem in which iterators would omit a few unmapped reads that should have been produced; cf #1142.)
This has probably been reported multiple times: #1279 as listed (first and best researched, so the credit for Daniel is certainly deserved), but also samtools/samtools#1451, possibly #1290, probably #1305 and samtools/samtools#1457, and perhaps samtools/samtools#1460.
Over in samtools, this could be described in terms of region queries instead:
Fixed
samtools view FILE REGION
andmpileup -r REGION
etc region queries: fixed bug introduced in 1.12, which lead to region queries producing very few reads for […]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying. It'd probably be worth listing the additional bug report numbers, and I'm afraid it should be s/lead/led/
— I'm pretty good at mixing that one up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the other bug reports should be mentioned in the SAMtools news, as they are related to running samtools commands.
NEWS
Outdated
number of contigs from an index. | ||
(#1295 and #1299) | ||
|
||
* Added bracket handling to bcf_hdr_parse_line. Thanks to Alberto Casas Orrtiz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added bracket handling to bcf_hdr_parse_line. Thanks to Alberto Casas Orrtiz. | |
* Added bracket handling to bcf_hdr_parse_line. Thanks to Alberto Casas Ortiz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'm too heavy on the 'R' key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update my latest commit to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(More for the trivia commit: there were a few trailing spaces near the Hulselmans entry too.)
ce50bd1
to
f0c0c96
Compare
Add a little more explanation, and try to describe the outcome of some of the changes for end users.
I've added a few adjustments, to better describe the outcome of some of the changes listed from an end-user perspective. |
Please take a look for errors, omissions or entirely fictional updates.
This will be kept updated until we are ready for a release.